CWE-778 Insufficient Logging, updating Readme and code files. #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Costello <[email protected]>
BartKaras1128
suggested changes
Apr 10, 2025
Contributor
BartKaras1128
left a comment
BartKaras1128
left a comment
There was a problem hiding this comment.
Just a few small spelling errors, missing bullet points and linting error.
docs/Secure-Coding-Guide-for-Python/CWE-693/CWE-778/compliant01.py
Outdated
Show resolved
Hide resolved
docs/Secure-Coding-Guide-for-Python/CWE-693/CWE-778/noncompliant01.py
Outdated
Show resolved
Hide resolved
myteron
reviewed
Apr 10, 2025
Contributor
myteron
left a comment
myteron
left a comment
There was a problem hiding this comment.
some minor comments, approved otherwise.
Co-authored-by: myteron <[email protected]> Signed-off-by: andrew-costello <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: andrew-costello <[email protected]>
…nt01.py Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: andrew-costello <[email protected]>
…1.py Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: andrew-costello <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: andrew-costello <[email protected]>
Signed-off-by: andrew-costello <[email protected]>
Co-authored-by: myteron <[email protected]> Signed-off-by: andrew-costello <[email protected]>
Signed-off-by: andrew-costello <[email protected]>
Signed-off-by: andrew-costello <[email protected]>
Signed-off-by: andrew-costello <[email protected]>
Contributor
Author
|
I updated the files based on the comments, please look over this again and continue with the review. Thank you. |
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: andrew-costello <[email protected]>
myteron
approved these changes
Apr 17, 2025
myteron
approved these changes
Apr 17, 2025
Contributor
myteron
left a comment
myteron
left a comment
There was a problem hiding this comment.
Approved,
not sure if we should log a zerodivision as critical tho.
myteron
approved these changes
Apr 17, 2025
Signed-off-by: Helge Wehder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.